Closed robertmin1 closed 1 year ago
This is a fix for https://github.com/namecoin/certinject/issues/78 , right?
You should be able to fix the linter warnings by adding the missing initialisms to https://github.com/namecoin/certinject/blob/ae33c55239f7355f32d9ba3ad95d4fba2e4a852b/certblob/generate.sh#L16 .
A separate PR was created to fix the Go Lint issues in the file propids.go. PR #88
I think it's OK to have #88 as a second commit in this PR rather than a separate PR, sine adding those initialisms is only relevant because of this PR.
Okay!
Squashed the two commits.
Can you put Fixes #78
in the first GitHub post of this PR so that GitHub properly handles the linkage between the PR and the issue?
Also can you edit the comment in generate.sh
lines 6-9 so that everyone can easily audit where the new header came from?
Made the relevant changes
I can confirm that wincrypt.h
from 1777946dfc4f01f91bc9dad9c48d358e36faed0b matches the content of the MinGW URL.
ACK 1777946dfc4f01f91bc9dad9c48d358e36faed0b
Fixes #78 Sending the MinGW-w64 header.