search

namecoin / certinject

Inject certificates into Windows CryptoAPI trust store, with EKU and name constraints.
https://www.namecoin.org/
GNU General Public License v3.0
2 stars 6 forks source link

MinGW-w64 header #87

Closed robertmin1 closed 1 year ago

robertmin1 commented 1 year ago

Fixes #78 Sending the MinGW-w64 header.

JeremyRand commented 1 year ago

This is a fix for https://github.com/namecoin/certinject/issues/78 , right?

You should be able to fix the linter warnings by adding the missing initialisms to https://github.com/namecoin/certinject/blob/ae33c55239f7355f32d9ba3ad95d4fba2e4a852b/certblob/generate.sh#L16 .

robertmin1 commented 1 year ago

A separate PR was created to fix the Go Lint issues in the file propids.go. PR #88

JeremyRand commented 1 year ago

I think it's OK to have #88 as a second commit in this PR rather than a separate PR, sine adding those initialisms is only relevant because of this PR.

robertmin1 commented 1 year ago

Okay!

robertmin1 commented 1 year ago

Squashed the two commits.

JeremyRand commented 1 year ago

Can you put Fixes #78 in the first GitHub post of this PR so that GitHub properly handles the linkage between the PR and the issue?

Also can you edit the comment in generate.sh lines 6-9 so that everyone can easily audit where the new header came from?

robertmin1 commented 1 year ago

Made the relevant changes

JeremyRand commented 1 year ago

I can confirm that wincrypt.h from 1777946dfc4f01f91bc9dad9c48d358e36faed0b matches the content of the MinGW URL.

JeremyRand commented 1 year ago

ACK 1777946dfc4f01f91bc9dad9c48d358e36faed0b