namecoin / electrum-nmc

Namecoin port of Electrum Bitcoin client.
https://www.namecoin.org/
MIT License
29 stars 24 forks source link

Static analysis for rebranding #106

Closed JeremyRand closed 5 years ago

JeremyRand commented 5 years ago

I wrote a static analysis script that looks for likely rebranding errors, and also fixed all the issues it found.

JeremyRand commented 5 years ago

Looks like the message signing unit test was expecting the wrong behavior. Now that it's fixed, the test fails. How nice. I'll fix that before trying to merge.

JeremyRand commented 5 years ago

Looks like the message signing unit test was expecting the wrong behavior. Now that it's fixed, the test fails. How nice. I'll fix that before trying to merge.

Fixed. If this PR passes Travis, then I think it's ready to merge.

JeremyRand commented 5 years ago

Passed Travis, modulo the known AppImage bug that's not related to this PR. Merging.