namecoin / electrum-nmc

Namecoin port of Electrum Bitcoin client.
https://www.namecoin.org/
MIT License
29 stars 24 forks source link

run_electrum_nmc not included in Windows binary? #143

Closed somewhatnmc closed 5 years ago

somewhatnmc commented 5 years ago

Receiving a fatal error on Windows 10. The run_electrum_nmc script does not appear to be included.

somewhatnmc commented 5 years ago

Same issue using the installer, can't find the run_electrum_nmc file in folder.

JeremyRand commented 5 years ago

Can you post the exact text and a screenshot of the error you're getting?

JeremyRand commented 5 years ago

I did an initial look-through of the Windows build code and I don't see anything that would be likely to cause this symptom; a screenshot and exact text would be helpful in tracking down the bug.

somewhatnmc commented 5 years ago

runElectrum

somewhatnmc commented 5 years ago

Traceback (most recent call last): File "run_electrum_nmc", line 359, in File "electrum_nmc\daemon.py", line 348, in init_gui ModuleNotFoundError: No module named 'electrum_nmc.gui.qt'

JeremyRand commented 5 years ago

Hmm, with the installer version, can you provide a screenshot of the contents of the directory you installed it to? (The directory that has the electrum_nmc and contrib subdirectories in it.)

JeremyRand commented 5 years ago

Ah, hmm, I'm looking at the line that the traceback mentions. It's definitely a piece of code that I fiddled with recently. Is there a file called daemon.py anywhere in the installation folder (using the installer)? If so, can you look at line 348 of it, and try changing the electrum_nmc on that line to electrum? There are two instances of it on that line; try changing each one individually, and also try changing them both, and let me know which sets of changes make a difference (if any do).

somewhatnmc commented 5 years ago

I can't find daemon.py unfortunately.

JeremyRand commented 5 years ago

I can reproduce the dialog in the screenshot on my Windows machine. What exactly did you do to produce the traceback that you pasted?

somewhatnmc commented 5 years ago

dir

JeremyRand commented 5 years ago

Interestingly, the Python zip works fine on Windows, so I assume there's an issue with the .exe packaging scripts somewhere. Not sure exactly where though.

somewhatnmc commented 5 years ago

(this is where it gets annoying for you i think )using bash ./electrum-nmc-nc3.3.6.exe

JeremyRand commented 5 years ago

hmm, I wonder if the PE header trick I used for certutil will be able to approximate the behavior you're achieving via bash....

somewhatnmc commented 5 years ago

For context, I had used 3.3.3.1.1.(1) on this machine with no issue.

somewhatnmc commented 5 years ago

I am somewhat indisposed so may take time to respond. Apologies.

JeremyRand commented 5 years ago

Well, I figured out how to extract a PyInstaller exe file, and I definitely see something wrong. Electrum-NMC's exe file doesn't have any of the Python modules for the electrum_nmc.gui package, whereas upstream Electrum (same version) does have them. I have no idea why exactly they're missing though. This certainly explains the traceback you got.

JeremyRand commented 5 years ago

I have a lead, but it's not a very likely one. Will hopefully have more info on whether that lead has panned out in circa 30 minutes.

JeremyRand commented 5 years ago

Pursuing another couple of leads...

JeremyRand commented 5 years ago

Relatively sure I see what's wrong. Fix will hopefully be out tomorrow.