Closed JeremyRand closed 4 years ago
I'll merge this if Travis passes (modulo the Regtest job).
This breaks the unit tests, so not merging for now. If needed I'll come back to this PR.
@gits7r Can you try cherry-picking https://github.com/namecoin/electrum-nmc/pull/195/commits/baf18aeef1b216235f16b85431bd5fe01563f1cc and check whether it fixes https://github.com/namecoin/electrum-nmc/issues/241 ?
This breaks the unit tests, so not merging for now. If needed I'll come back to this PR.
The unit tests are fixed, so if this is confirmed to fix https://github.com/namecoin/electrum-nmc/issues/241 then we should be able to merge it.
I can confirm that it fixes #241 for me; merging shortly. If there are any remaining issues we can open a new ticket for those.
I'll backport this to master-3.3.10
as well.
I'll backport this to
master-3.3.10
as well.
Backport complete.
yes this fixes it as well. but we already used 100x bitcoin fees, i guess we did not add it at the last upstream refactor. seams ok.
Fixes https://github.com/namecoin/electrum-nmc/issues/241