search

namecoin / electrum-nmc

Namecoin port of Electrum Bitcoin client.
https://www.namecoin.org/
MIT License
29 stars 24 forks source link

Fix missing Qt forms when installed via setup.py #225

Closed JeremyRand closed 4 years ago

JeremyRand commented 4 years ago

@gits7r Can you try cherry-picking this and see if it fixes the pip issue you reported on IRC?

gits7r commented 4 years ago

It does not fix it. I mean it removes the gui.qt.forms error but fails with another:

Traceback (most recent call last): File "/usr/local/bin/electrum-nmc", line 4, in import('pkg_resources').run_script('Electrum-NMC==3.3.8', 'electrum-nmc') File "/usr/lib/python3/dist-packages/pkg_resources/init.py", line 666, in run_script self.require(requires)[0].run_script(script_name, ns) File "/usr/lib/python3/dist-packages/pkg_resources/init.py", line 1437, in run_script .format(**locals()), pkg_resources.ResolutionError: Script 'scripts/electrum-nmc' not found in metadata at '/usr/local/lib/python3.7/dist-packages/Electrum_NMC-3.3.8.dist-info'

As I said this also happens upstream, so we should see what was changed there and how it is fixed there and maybe cherry pick for our 3.3.8-1 branch that will remain stable for a while until all the auxpow stuff gets done.

JeremyRand commented 4 years ago

It does not fix it. I mean it removes the gui.qt.forms error but fails with another:

@gits7r Okay, interesting. AFAICT the forms error was Namecoin-specific; if this PR fixes that issue then I think it's okay to merge even if there's some other orthogonal error.

As I said this also happens upstream, so we should see what was changed there and how it is fixed there and maybe cherry pick for our 3.3.8-1 branch that will remain stable for a while until all the auxpow stuff gets done.

Okay. Let's discuss that one in a separate issue.