namecoin / electrum-nmc

Namecoin port of Electrum Bitcoin client.
https://www.namecoin.org/
MIT License
29 stars 24 forks source link

Fix delta computation for name transfers #244

Closed domob1812 closed 4 years ago

domob1812 commented 4 years ago

get_wallet_name_delta was broken for the situations of name transfers (i.e. where one input is in the wallet and the other is not). This was due to a typo, where the domain check for name outputs was still done on the (last) tx input address.

This change fixes the issue, and also makes the code a bit more readable with extracting and sharing the long condition into a helper function.

JeremyRand commented 4 years ago

utACK 16b5fe7180e7189d79d02b8c630f1c75b7b30bce