search

namecoin / electrum-nmc

Namecoin port of Electrum Bitcoin client.
https://www.namecoin.org/
MIT License
29 stars 24 forks source link

Add constant for name expiration. #245

Closed domob1812 closed 4 years ago

domob1812 commented 4 years ago

Add the number of blocks before names expire as network constant rather than hardcoding it in place, and change it to 30 on regtest.

JeremyRand commented 4 years ago

Grepping for 35999 yields one place you missed (in commands.py).

JeremyRand commented 4 years ago

Also I think you're missing a definition for testnet.

domob1812 commented 4 years ago

@JeremyRand Oh yes, good points. I've fixed both of them. (I was under the impression that the "testnet" constants derive from mainnet as they do in Namecoin Core, which would have made a separate definition unnecessary. But apparently constants for testnet are duplicated in Electrum even if they do match the mainnet values.)

JeremyRand commented 4 years ago

utACK 4d212a8f986f2955a293b2f5df18af0d7be883fb