search

namecoin / electrum-nmc

Namecoin port of Electrum Bitcoin client.
https://www.namecoin.org/
MIT License
29 stars 24 forks source link

Investigate subclassing upstream Electrum classes #273

Open JeremyRand opened 3 years ago

JeremyRand commented 3 years ago

It would be interesting to explore making Electrum-NMC's Python classes subclasses of upstream Electrum's, rather than forks of them. This would potentially cut down on maintenance effort substantially.

JeremyRand commented 3 years ago

@domob1812 What's your take on this suggestion? AFAICT using subclasses instead of editing the existing classes would reduce merge conflicts, but it would also increase the risk of us failing to notice an upstream change that requires a patch on our end. I tend to think the latter is not a big issue for us, since integration tests are likely to catch those cases anyway, and the decreased maintenance effort would be a big win.

domob1812 commented 3 years ago

I think it is a very interesting idea. However, I also think that some of the changes we need to do might be hard to implement by pure subclassing (but maybe I'm wrong here, or just don't have enough Python experience to judge this).

It would definitely be interesting to give it a try if you have time for it.