namecoin / electrum-nmc

Namecoin port of Electrum Bitcoin client.
https://www.namecoin.org/
MIT License
29 stars 24 forks source link

Offer the possibility to customize renewal transactions or at least view them before signing and broadcasting #275

Open gits7r opened 3 years ago

gits7r commented 3 years ago

Currently, if you try to "send" some namecoins in Electrum-NMC you have the possibility to also set a fee, with an estimator that has 3 modes. This is perfect, expected and requried.

However, when you try to "Renew" a name you have under your property, it will just ask for the wallet password and proceed with the renewal transaction, also automatically setting the fee to whatever the slider was set in the "Send" tab. Or maybe it's unrelated to the slider in "Send" tab and it was just a coincidence for me that the fee was the same.

It would make sense to pop-up a window with the renewal transaction to allow the user to view it before requiring wallet password, signing and broadcasting. There the user can see the address to which the name is being sent, the fee, which utxo is being spent, etc. - exactly like electrum has advanced preview in latest versions. Some fields should be allowed to be edited by the user manually before tx is signed and broadcasted.