namecoin / electrum-nmc

Namecoin port of Electrum Bitcoin client.
https://www.namecoin.org/
MIT License
29 stars 24 forks source link

NoneType object not subscriptable minor usability bug #279

Open gits7r opened 3 years ago

gits7r commented 3 years ago

To reproduce:

Go to "Manage Names" tab, secondary click on any domain name or identity and click "Renew". Password pop-up will appear if wallet is password protected. Click "Cancel". Instead of interrupt process without further input from the app, we get: nmc-err

If Cancel is pressed on the password prompt, the process should end gracefully without trying to sign something or process the function further.

Secondary, go to "Manage Names" tab, secondary click on any domain name or identity and click "Configure". The editor pop-up will appear. If you click "Cancel", the process is abandoned smoothly, however if you click OK on the editor pop-up without entering any data at all or editing the existing data (if any), the password pop-up will appear like it will try to sign something, and if you click Cancel on the password prompt you get: nmc-err2

If no data at all is entered, or pre-existent data in the editor pop-up is not modified at all, OK should have the same effect as Cancel button on the editor pop-up box, without going all the way to ask for the wallet password and try to sign something.