search

namecoin / electrum-nmc

Namecoin port of Electrum Bitcoin client.
https://www.namecoin.org/
MIT License
29 stars 24 forks source link

AuxPoW: Remove calculate_merkle_root #280

Closed JeremyRand closed 3 years ago

JeremyRand commented 3 years ago

It duplicates functionality of SPV.hash_merkle_root.

JeremyRand commented 3 years ago

The auxpow tests pass with this PR. I see a couple of DNSSEC test failures, and a regtest failure, all of which I'm guessing are expected for an outdated upstream. I'll double-check that before merging this.

JeremyRand commented 3 years ago

The auxpow tests pass with this PR. I see a couple of DNSSEC test failures, and a regtest failure, all of which I'm guessing are expected for an outdated upstream. I'll double-check that before merging this.

Confirmed; those failures also occur in our bitcoin branch at the moment; they're not the fault of this PR or anything specific to the auxpow or master branches. Merging.