search

namecoin / electrum-nmc

Namecoin port of Electrum Bitcoin client.
https://www.namecoin.org/
MIT License
29 stars 24 forks source link

Remove compiled forms from tarballs submitted to packagers #292

Open JeremyRand opened 2 years ago

JeremyRand commented 2 years ago

Currently, our tarballs contain both the XML source of our Qt forms, and the compiled Python of those forms. This violates Debian policy:

The source code archive should contain source files only, never any files that are automatically generated from other files.

We should look at removing the compiled forms from the tarballs that are submitted to Debian packagers.

Relatedly, the contrib/make_qt_forms script is not included in our tarballs; this also violates Debian policy:

we need to rebuild all generated files to make sure that they can really be built from source, so please include methods to regenerate these files

We should add that script.

JeremyRand commented 2 years ago

Also related: the tarballs contain a packages folder, which contains embedded library dependencies; this violates Debian policy and should also be removed:

Please do not include other code (like libraries) or data that are also shipped separately inside your source archive

That's an upstream issue though.

JeremyRand commented 2 years ago

Currently, our tarballs contain both the XML source of our Qt forms, and the compiled Python of those forms. This violates Debian policy:

The source code archive should contain source files only, never any files that are automatically generated from other files.

We should look at removing the compiled forms from the tarballs that are submitted to Debian packagers.

Ditto for paymentrequest_pb2.py, which is generated from paymentrequest.proto. That's also an upstream issue though.

JeremyRand commented 2 years ago

Currently, our tarballs contain both the XML source of our Qt forms, and the compiled Python of those forms. This violates Debian policy:

The source code archive should contain source files only, never any files that are automatically generated from other files.

We should look at removing the compiled forms from the tarballs that are submitted to Debian packagers.

I think this is fixed in the 4.0.0b1 branch (not master), but haven't tested.

Relatedly, the contrib/make_qt_forms script is not included in our tarballs; this also violates Debian policy:

we need to rebuild all generated files to make sure that they can really be built from source, so please include methods to regenerate these files

We should add that script.

Guessing this is not fixed yet.