namecoin / electrum-nmc

Namecoin port of Electrum Bitcoin client.
https://www.namecoin.org/
MIT License
29 stars 24 forks source link

ManageNames Tab: allow deleteion of expired domain names, clarify the message for renewal of taken names, highlight with red such names #294

Open gits7r opened 2 years ago

gits7r commented 2 years ago

Directly related to this is #162 Indirectly related to this is also #266 (allow a way to delete pending registration transactions that will never be completed).

Currently there is no way to delete an expired name from the ManageNames tab, even it is already expired and registered by someone else. Also, when you try to renew an expired domain name that has been already taken during the expiration date till you try to renew it (assuming it was not renewed before its expire date of course) you will get:

asdadada

We should clarify this message that it's not an error -- the name in question has been registered on the namecoin blockchain by other wallet / user. The user should understand this that there is no sense trying to renew it with a different ElectrumX-NMC server or something.

Also the EXPIRING names (that are to expire in say 4300 blocks with orange color and bolder text) and EXPIRED names (already expired) with red color and bold\italic text -- do you think this is a good idea?

JeremyRand commented 2 years ago

Currently there is no way to delete an expired name from the ManageNames tab, even it is already expired and registered by someone else.

I'm leaning toward putting a checkbox on the Manage Names tab, which lets you toggle whether expired names are shown.

Also, when you try to renew an expired domain name that has been already taken during the expiration date till you try to renew it (assuming it was not renewed before its expire date of course) you will get:

asdadada

We should clarify this message that it's not an error -- the name in question has been registered on the namecoin blockchain by other wallet / user. The user should understand this that there is no sense trying to renew it with a different ElectrumX-NMC server or something.

Would the approach in https://github.com/namecoin/namecoin-core/pull/408 be okay?

Also the EXPIRING names (that are to expire in say 4300 blocks with orange color and bolder text) and EXPIRED names (already expired) with red color and bold\italic text -- do you think this is a good idea?

I'd want to confer with a UX specialist (e.g. Diego from Monero) about exactly what formatting attributes are desirable here, but I have no objection to having special formatting for expired names and names that will soon expire.