Fix icon: replace bitcoin.png with namecoin.png

namecoin / electrum-nmc

Namecoin port of Electrum Bitcoin client.

https://www.namecoin.org/

MIT License

29 stars 24 forks source link

Fix icon: replace bitcoin.png with namecoin.png #302

Closed mrpeertopeer closed 2 years ago

mrpeertopeer commented 2 years ago

Issue:

The bitcoin icon is displayed on the request button and in the incoming transactions section:

request

incoming

Changes:

Delete bitcoin.png
Add namecoin.png
Change icon from bitcoin.png to namecoin.png in electrum/gui/qt/main_window.py and electrum/gui/qt/request_list.py

yanmaani commented 2 years ago

I think the reasonable thing to do here would be to keep the name as bitcoin.png but change it to the Namecoin logo; this helps keep our diff against upstream small.

mrpeertopeer commented 2 years ago

@yanmaani This is a minor change, and it is not the first time such a renaming has occurred.

See https://github.com/namecoin/electrum-nmc/blob/master/electrum_nmc/electrum/gui/icons/electrum_nmc.png, which must be fixed in accordance with https://github.com/namecoin/electrum-nmc/issues/288.

yanmaani commented 2 years ago

it is not the first time such a renaming has occurred

Link?

mrpeertopeer commented 2 years ago

electrum.png to electrum_nmc.png

https://github.com/spesmilo/electrum/blob/master/electrum/gui/icons/electrum.png to https://github.com/namecoin/electrum-nmc/blob/master/electrum_nmc/electrum/gui/icons/electrum_nmc.png

mrpeertopeer commented 2 years ago

I'm closing this. Do not merge it or I sue you for copyright infringement. You cunt.

yanmaani commented 2 years ago

Actually, by section D.6 of the GitHub Terms of Service, you irrevocably licensed your contribution under the MIT when you made a pull request to this repository. You cannot sue anyone for merging it.