Closed robertmin1 closed 10 months ago
I'd prefer not to commit compiled form files into Git; those files are already generated at build time, which is preferred by the Debian guys.
Alright! I'm not sure why it has a copy of #338. I will check this out
Fixed the two issues
It looks like you're using bytes.fromhex
etc. for messing with the encoding. We already have encoding/decoding functions in names.py
that you can use for this, which will ensure consistency with Namecoin Core behavior.
Switched to the encoding/decoding functions in names.py
This looks pretty good so far.
Initial feedback:
Keep it up! :)
I tried typing hex that was invalid ASCII (e.g. ffffff
) and the preview didn't update; I suspect that the preview is incorrectly retrieving its data from the ASCII textbox instead of the Hex textbox.
A helper function might be helpful to handle the state of buttons and labels?
def update_buttons_and_label(self, condition=None, button=None, label=None, error_message=None):
if button is not None:
button.setEnabled(condition)
if label is not None:
if error_message:
label.setText(error_message)
else:
label.clear()
Is the idea to reuse that helper function across the Buy Names page, the Configure Name page, etc.? If so, yeah I think that's reasonable.
Typing a string that doesn't end in .bit
to the Domain textbox seems to cause the string to be copied verbatim to the ASCII textbox instead of producing an error.
As discussed, no further changes are needed, but can you squash the commits, and then remove WIP:
from the PR title?
ACK 32af8d858c5a350d859728385c2c816b2621084d
It looks like this contains a copy of https://github.com/namecoin/electrum-nmc/pull/338 . Is that because there would be merge conflicts otherwise?