namecoin / electrum-nmc

Namecoin port of Electrum Bitcoin client.
https://www.namecoin.org/
MIT License
29 stars 24 forks source link

Electrum icon filename needs rebranding #99

Closed JeremyRand closed 5 years ago

JeremyRand commented 5 years ago

The following error shows up in the AppImage build once the fix in https://github.com/namecoin/electrum-nmc/pull/97 is applied:

electrum-nmc{.png,.svg,.svgz,.xpm} defined in desktop file but not found
For example, you could put a 256x256 pixel png into
/opt/electrum-nmc/contrib/build-linux/appimage/build/appimage/electrum-nmc.AppDir/electrum-nmc.png

The build error is caused by the .desktop file calling for an icon called electrum-nmc whereas the actual icon file we have isn't rebranded (it's still called electrum). According to the relevant spec we should rename the icon file, because in its current form it looks like Electrum-NMC will conflict with upstream Electrum if installed on the same system.