namecoin / heteronculous-horklump

Go port of Heteronculous (ptrace-based proxy leak detector). Outreachy project.
GNU General Public License v3.0
7 stars 3 forks source link

GenerateRandomCredentials errors not being checked #47

Closed JeremyRand closed 1 year ago

JeremyRand commented 1 year ago

In a couple places, the error returned by GenerateRandomCredentials is discarded:

This seems dangerous, as it will cause stream isolation to be silently disabled if the PRNG fails for some reason.

robertmin1 commented 1 year ago

Implemented, but the error will be handled through panic, since it's not in the strace.Trace funciton. A warning can also be used, but panic might be better

robertmin1 commented 1 year ago

Checking the errors