namecoin / namecoin-core

Namecoin full node + wallet based on the current Bitcoin Core codebase.
https://www.namecoin.org/
MIT License
461 stars 148 forks source link

Qt: Coin Control for name transactions #183

Open JeremyRand opened 7 years ago

JeremyRand commented 7 years ago

Describe the issue

Name transactions created with Namecoin-Qt should support Coin Control.

Can you reliably reproduce the issue?

If so, please list the steps to reproduce below:

  1. Settings -> Options -> Wallet -> Enable coin control features -> Checked.
  2. Go to the Manage Names tab.

Expected behaviour

The "Coin Control Features" widget should be present (and it should work properly).

Actual behaviour

The "Coin Control Features" widget is not present.

Screenshots.

(Screenshots probably available on request.)

What version of namecoin-core are you using?

Namecoin Core version nc0.13.99-name-tab-beta1 (64-bit). Official binary.

Machine specs:

JeremyRand commented 7 years ago

The raw transaction API is an obvious way to solve this, but doing so for name registrations is blocked by #181 (specifically the issues that name_new and name_firstupdate outputs can't be created). (This blockage doesn't apply to name_update transactions.)

JeremyRand commented 6 years ago

The raw transaction API is an obvious way to solve this, but doing so for name registrations is blocked by #181 (specifically the issues that name_new and name_firstupdate outputs can't be created). (This blockage doesn't apply to name_update transactions.)

181 is resolved now. Proof of concept of coin control for name registration is at https://github.com/JeremyRand/namecoin-raw-tx-api/blob/master/automatic_registration.py (should work with Namecoin Core master branch).

JeremyRand commented 3 years ago

Relevant: https://github.com/namecoin/namecoin-core/issues/463 would allow us to do this without calling the raw transaction API from Qt code.