search

namecoin / namecoin-core

Namecoin full node + wallet based on the current Bitcoin Core codebase.
https://www.namecoin.org/
MIT License
460 stars 147 forks source link

Remove getauxblock #295

Open domob1812 opened 5 years ago

domob1812 commented 5 years ago

Upstream Bitcoin removed generate and with that is now trying to decouple the wallet and mining code increasingly. In Namecoin, we still have getauxblock that is a "wallet mining" command. This is creating more and more maintenance headaches with upstream merges.

We already have createauxblock and submitauxblock since quite some time, which can be used instead of getauxblock with an explicitly provided address (i.e. without the need to tie in with an internal wallet).

What do you think (especially miners) about removing getauxblock for 0.19+ completely? @wangchun, @YihaoPeng, @JeremyRand

JeremyRand commented 5 years ago

This tentatively sounds good to me (coupling the wallet and mining code never seemed sane to me), but I'll defer an ACK/NACK until we've heard from the miner community.

domob1812 commented 5 years ago

On second thought, this is not as high priority for me as it seemed. The problem is that even if we can remove getauxblock from Namecoin, we most likely need to keep getwork around for Xaya a bit longer. So from my point of view, maintenance work will remain up.

That said, I still think it would be good for Namecoin and the longer-term development if we could get rid of getauxblock.