search

namecoin / namecoin-core

Namecoin full node + wallet based on the current Bitcoin Core codebase.
https://www.namecoin.org/
MIT License
455 stars 147 forks source link

Tag nc22.0 #491

Open JeremyRand opened 2 years ago

JeremyRand commented 2 years ago

I've just pushed a 22.0-draft branch. This branch is identical to nc0.22.0 except 3 backported bugfixes from the 22.x branch have been cherry-picked. @domob1812 Can you take a look at the 22.0-draft branch and check that it looks okay? If it passes your review, can you rename that branch to 22.0 (i.e. remove the -draft suffix) and tag it as nc22.0 (no leading 0. in the version number)?

domob1812 commented 2 years ago

Out of curiosity, what are the backports and why can't we use the 22.x branch as basis?

JeremyRand commented 2 years ago

They're the same bugfixes that we already backported to 22.x from master. I'm hesitant to tag from 22.x directly since that contains upstream Bitcoin commits that aren't part of a Bitcoin tag, which means they've gotten less QA testing and makes it harder for Namecoin users to reason about what Bitcoin commits they're getting from our tag.

domob1812 commented 2 years ago

Makes sense, all done.