Open ghost opened 2 years ago
Probably a missing #include <optional>
(which is fixed in master
).
I don't think its fixed in master
. This fixes it:
diff --git a/src/qt/buynamespage.h b/src/qt/buynamespage.h
index 03a565c..1aa3097 100644
--- a/src/qt/buynamespage.h
+++ b/src/qt/buynamespage.h
@@ -5,6 +5,8 @@
#include <QWidget>
+#include <optional>
+
class WalletModel;
namespace Ui {
Hi @ncopa , thanks for the patch. Would you mind creating a PR for that, so that we can review it properly? It definitely looks like this bug only gets tickled in certain cases, and for whatever reason it doesn't get tickled in either my personal build VM or Guix, but as long as the PR is obviously correct, I'm not too worried about figuring out how to reproduce the bug on my end -- adding an #include
doesn't need that much review.
EDIT: Also apologies for missing your patch when you posted it; your comment was posted while I had COVID. :(