namecoin / namecoin-core

Namecoin full node + wallet based on the current Bitcoin Core codebase.
https://www.namecoin.org/
MIT License
455 stars 147 forks source link

Restore RPC "toaddress" #530

Closed ghost closed 1 year ago

ghost commented 1 year ago

The current RPC command, which introduced so-called options by Daniel Kraft @domob1812 in https://github.com/namecoin/namecoin-core/pull/220, is completely broken.

Names that are not in the hardcoded d/ dd/ id/ idd/ namespaces cannot be transferred. &namespace/name, for example, will fail miserably. Nearly losing names in https://github.com/namecoin/namecoin-core/issues/524

Worse, after such a "option" transfer, name_show returns a different owner for the name in RPC and console. RPC displays a different owner than the console.

Propose to restore Namecoin inventor Vincent Durham (@vinced) original RPC command:

namecoin-cli name_update "myname", "new-value", "NE00nME0p0iyNK0gFh0FUeUriHXxEFemo0"

namecoin-cli name_update name value toaddress

JeremyRand commented 1 year ago

Duplicate of https://github.com/namecoin/namecoin-core/issues/524