namecoin / namecoin-core

Namecoin full node + wallet based on the current Bitcoin Core codebase.
https://www.namecoin.org/
MIT License
455 stars 147 forks source link

Don't hide name ops sent to change addresses #536

Closed JeremyRand closed 3 months ago

JeremyRand commented 3 months ago

This particularly matters because the name_new RPC method sends to a change address by default, so if you issued a name_new, it would never show up in the Transactions tab.

domob1812 commented 3 months ago

ACK c2b76c7fbcc7f04930dc6254489692edd7023681. I may not be able to merge this until in a few days, though, as I'm currently not at my main computer.

JeremyRand commented 3 months ago

ACK c2b76c7. I may not be able to merge this until in a few days, though, as I'm currently not at my main computer.

@domob1812 Is it OK if I merge this myself (via the github-merge.py script)? I have some other work I'm doing that's blocked on getting this merged.

domob1812 commented 3 months ago

Yes if you can then please do so, exactly with that script.