namecoin / namecoin-core

Namecoin full node + wallet based on the current Bitcoin Core codebase.
https://www.namecoin.org/
MIT License
463 stars 147 forks source link

Add Namecoin developer GPG pubkeys for Gitian use #81

Open JeremyRand opened 8 years ago

JeremyRand commented 8 years ago

From #namecoin-meeting:

Mar 06 19:43:47 <Jeremy_Rand>   Erkan_Yilmaz: Gitian has a nice signature system, so if you have the GPG pubkeys of the various developers, Gitian can automatically verify that the build is trustworthy and tell you who reproduced the hashes
Mar 06 19:44:17 <qpm>   freenode:<Erkan_Yilmaz> I see
Mar 06 19:44:19 <Jeremy_Rand>   Bitcoin has the GPG pubkeys of the Gitian signers in their repo; we should probably do so as well
Mar 06 19:45:07 <qpm>   freenode:<cassiniNMC> ACK
Mar 06 19:46:02 <Jeremy_Rand>   cassiniNMC: are you ACKing posting binaries when 1 dev has posted Gitian sigs, or are you ACKing putting GPG pubkeys of the devs in the GitHub repo?
Mar 06 19:46:27 <qpm>   freenode:<cassiniNMC> both
Mar 06 19:46:29 <Jeremy_Rand>   ok
Mar 06 19:46:54 <Jeremy_Rand>   sounds good

Details are briefly mentioned at https://github.com/namecoin/namecoin-core/blob/master/doc/release-process.md#verify-other-gitian-builders-signatures-to-your-own-optional .

The 4 Namecoin developers I'm aware of who use Gitian are me, @josephbisch, @jonasbits, and @midnightmagic . @ryancdotorg has also expressed interest in the past. Are you guys okay with adding your GPG pubkeys to the namecoin-core repo? (I guess midnight's is already there, since he does Gitian builds for Bitcoin.)

midnightmagic commented 8 years ago

ACK! All this sounds great to me! How can I help?

josephbisch commented 8 years ago

I don't see why not.

JeremyRand commented 8 years ago

Should we remove the Bitcoin developers' GPG keys from our repo, or have them coexist with ours? Seems kind of weird to keep keys of people who aren't involved in the project in our repo. However, since Luke-Jr did do Gitian builds of Namecoin Core for Eligius, I'd say that if we remove the Bitcoin developers' keys, Luke's key should remain. Opinions?

Also I checked; @midnightmagic 's key isn't in the Bitcoin repo.

JeremyRand commented 8 years ago

Also tagging @brandonrobertz , the newest member of the Namecoin Gitian club.

brandonrobertz commented 8 years ago

I looked around and it seems fairly split between other coins. Litecoin keeps the bitcoin dev keys. Dogecoin has their own. I think it makes sense to leave folks who are even somewhat active and remove those we don't know or trust. $0.02

JeremyRand commented 8 years ago

For anyone who isn't aware, the reason I haven't yet committed my PGP pubkey is because I'm intending to create new keys in an offline VM. This was delayed by DWS, but I'm most likely going to be able to create new keys in the next week or so. I hope I'm not blocking anyone's progress?

domob1812 commented 6 years ago

I've added my own key for now in #223. @JeremyRand, I think you have a new key by now - please create a PR adding it. (Others feel free as well.)

I'm happy to keep Bitcoin developers for now - but we can also remove everyone except Luke if others prefer that.