namecoin / namecoin-legacy

Legacy client. New version here: https://github.com/namecoin/namecoin-core Note the release branch! - Official website:
https://namecoin.org
MIT License
448 stars 177 forks source link

Custom wallet filename option #121

Closed digital-dreamer closed 10 years ago

digital-dreamer commented 10 years ago

You can set walletpath=(file) in bitcoin.conf to use a custom wallet file. It doesn't have to be in the data directory, absolute and relative paths are supported too.

Implements feature request #78

domob1812 commented 10 years ago

I haven't yet tested it, but the code looks good (see my remarks). I think we can merge this after testing everything thoroughly (absolute / relative paths, backupwallet in particular).

digital-dreamer commented 10 years ago

I added a commit with the improvements. I tested both absolute/relative paths and wallet backups (from UI) and it seems to work fine, but it will be better it you check it too, in case I missed something,

phelixbtc commented 10 years ago

All these worked fine: namecoin-qt.exe -walletpath=wallet.dat_ant_test namecoin-qt.exe -walletpath=..\namecoin\wallet.dat_ant_test namecoin-qt.exe -walletpath=%appdata%\namecoin\wallet.dat_ant_test namecoin-qt.exe -walletpath=%appdata%/namecoin\wallet.dat_ant_test

phelixbtc commented 10 years ago

@digital-dreamer Would you like to fix it yourself or should I give it a try?

digital-dreamer commented 10 years ago

Is it OK now?

phelixbtc commented 10 years ago

ACK