search

namecoin / namecoin-legacy

Legacy client. New version here: https://github.com/namecoin/namecoin-core Note the release branch! - Official website:
https://namecoin.org
MIT License
448 stars 177 forks source link

fix #142 - proxy settings not loaded #144

Closed digital-dreamer closed 10 years ago

digital-dreamer commented 10 years ago

First problem: ApplyProxySettings() was not called on startup, which made the OptionsModel::data say there is no proxy, even if it is on. This causes the options dialog to show proxy as disabled, and if you then save it, it actually disables it.

Solution: Just call ApplyProxySettings() on init.

Second problem: After I fixed this, I found the opposite issue too. If you have proxy enabled, and you disable it in options, hit OK and then go to option again, you still see it as enabled. This was caused by another bug in ApplyProxySettings(). Function returns false before it can call SetProxy to set it to zero.

Solution: Add the missing call to SetProxy.

I also added a clarification of potentially confusing button text meanings in the Czech localization that I noticed while working on this.

phelixbtc commented 10 years ago

Looks good but unfortunately going through Tor does not work for me neither with nor without this patch.... anybody else?

phelixbtc commented 10 years ago

OK, works (original version did not). ACK