search

namecoin / namecoin-legacy

Legacy client. New version here: https://github.com/namecoin/namecoin-core Note the release branch! - Official website:
https://namecoin.org
MIT License
448 stars 177 forks source link

Add stricter check for Namecoin tx version. #197

Closed domob1812 closed 9 years ago

domob1812 commented 10 years ago

This patch proposes a softfork, after which stricter checks are done on the nVersion field of transactions with name outputs. In particular, currently name outputs are allowed also for transactions not marked as "Namecoin tx" by the version. (Inputs are disallowed.) This leads to strange situations, particularly when the outputs are name updates and not just NAME_NEW's. Fixing it seems like a good idea. This only affects transactions created by third-party clients. namecoind itself already sets the version correctly since the beginning.

This builds on https://github.com/namecoin/namecoin/pull/188.

domob1812 commented 10 years ago

The softfork height still needs to be set after it is decided when to do it. It can be combined with other proposed changes, like enforcing a minimum locked amount of coins in each name.

JeremyRand commented 10 years ago

I'm not qualified to review the code, but I have no problem with the proposed changes on a concept level.

phelixbtc commented 9 years ago

Compiles on Windows and downloads the blockchain. ACK