search

namecoin / ncbtcjson

Companion package to Conformal's btcjson, which adds Namecoin-specific RPC methods
https://www.namecoin.org/
ISC License
0 stars 4 forks source link

Fix defaults for NameShowOptions and NameScanOptions #5

Closed JeremyRand closed 4 years ago

JeremyRand commented 4 years ago

Fixes https://github.com/namecoin/ncbtcjson/issues/4

JeremyRand commented 4 years ago

@redblade7 Could you please try this patch and check:

  1. Whether it fixes old Namecoin Core compatibility.
  2. Whether it still works with the latest Namecoin Core.

Thanks.

redblade7 commented 4 years ago

I'm sorry, but I've never compiled the source for ncdns before. I never understood the instructions and remember getting it wrong the only time I tried, so I just always used the ncdns release binaries.

JeremyRand commented 4 years ago

Ok, no worries, I'll dig up an old 0.13.99-name-tab-beta1 installation here and see if I can test it locally.

JeremyRand commented 4 years ago

Okay, that was slightly trickier than I was expecting, but this should fix the situation now. Will merge shortly, and then tag new releases and build new binaries.

JeremyRand commented 4 years ago

@redblade7 v0.0.10.3 binaries are up on GitHub, can you try those and see if they fix your issue?