namecoin / ncdns-nsis

NSIS scripts for ncdns.
https://www.namecoin.org/
GNU General Public License v3.0
3 stars 8 forks source link

Work around PowerShell v2 bug #113

Closed JeremyRand closed 2 years ago

JeremyRand commented 2 years ago

Also other misc code quality improvements.

JeremyRand commented 2 years ago

"Explicitly invoke powershell.exe in Tor Browser scripts" breaks command-line args to the script. Will remove that one.

JeremyRand commented 2 years ago

Fixes the issue on Windows 7. Need to test the other changes on Windows 10.

JeremyRand commented 2 years ago

All changes tested and working on Windows 10. Will merge shortly.

Note that the upstream BIND and Python binaries still don't work on Windows 7, so this PR doesn't completely fix Windows 7 support. But it's clearly an improvement.

The Fedora Cirrus fail seems to be unrelated to this PR, maybe a Fedora bug.