Switch to rpcclient based on current upstream Conformal

JeremyRand commented 5 years ago

Namecoin's fork of Conformal's RPC client library is ancient and unmaintained; switching to upstream eliminates a major source of potential bugs (and known bugs, e.g. the ConsensusJ and Electrum compatibility bugs that we had to patch).

Fixes https://github.com/namecoin/ncdns/issues/9

TODO:

[ ] Wait for Conformal to merge https://github.com/btcsuite/btcd/pull/1457
[ ] Wait for Conformal to merge https://github.com/btcsuite/btcd/pull/1460
[x] Push name_show support for ncjson and ncrpcclient
[x] Implement cookie authentication
[x] Test cookie authentication

JeremyRand commented 5 years ago

Fixed merge conflict.

JeremyRand commented 5 years ago

Triggering a rebuild..

JeremyRand commented 5 years ago

Upstream delays have reached the point where continuing to block will mean our funding will grind to a halt. Since the status quo is a fork of Conformal, switching to a more recent fork of Conformal doesn't make anything worse, and will allow us to move forward with funded projects. This PR is therefore modified to point to a Namecoin fork of Conformal's repo. We will continue to work with Conformal to rectify the situation long-term, but for now we're going to merge this as-is.

namecoin / ncdns

Switch to rpcclient based on current upstream Conformal #103