With these changes, an error is returned if neither of the -certstore.nss or -certstore.cryptoapi flags are used. Without using one of these flags, errors were silently ignored while nothing actually was inserted or cleaned.
Keeping the Errorf and Fatal log lines around for now, until all the callers of InjectCert() and CleanCerts() handle the errors on their own. At that point it would be safe to remove the logged errors from this package and return errors for the main program to log and control verbosity.
With these changes, an error is returned if neither of the
-certstore.nssor-certstore.cryptoapiflags are used. Without using one of these flags, errors were silently ignored while nothing actually was inserted or cleaned.Keeping the
ErrorfandFatallog lines around for now, until all the callers ofInjectCert()andCleanCerts()handle the errors on their own. At that point it would be safe to remove the logged errors from this package and return errors for the main program to log and control verbosity.