search

namecoin / ncdns

:globe_with_meridians: Namecoin to DNS bridge daemon
https://www.namecoin.org/
GNU General Public License v3.0
134 stars 40 forks source link

Building on linux/amd64 #126

Open raws0cket opened 3 years ago

raws0cket commented 3 years ago

I'm trying to build via "option A" (https://github.com/namecoin/ncdns) At the last step (go get -t github.com/namecoin/ncdns/...) i have this error:

# github.com/namecoin/x509-signature-splice/x509
go/work/src/github.com/namecoin/x509-signature-splice/x509/x509_splice.go:142:36: not enough arguments in call to buildExtensions
        have (*Certificate, bool, []byte)
        want (*Certificate, bool, []byte, []byte)

Version of Go is 1.15

JeremyRand commented 3 years ago

Thanks for the bug report. Looks like you've hit this bug: https://github.com/namecoin/x509-signature-splice/issues/14

Is downgrading Go an option for you? Go 1.13.x definitely should work; Go 1.14.x might work too (not sure). The x509-signature-splice codebase is to-be-deprecated, since we've found better ways (e.g. https://github.com/namecoin/x509-signature-splice/issues/12 ) to achieve those goals, so I'm not particularly motivated to keep rebasing it periodically unless we have users who urgently need it to be rebased before those alternate methods are ready for release.

raws0cket commented 3 years ago

I have downgraded version of Go to 1.14.7 and it works.

c00w commented 3 years ago

FYI - go 1.13 is actually unsupported, and go1.14 will be unsupported when go 1.16 releases in febuary - any way you can just tag a new version since it looks like the fix is already merged?

JeremyRand commented 3 years ago

FYI - go 1.13 is actually unsupported, and go1.14 will be unsupported when go 1.16 releases in febuary - any way you can just tag a new version since it looks like the fix is already merged?

Thanks for the poke @c00w. Yes, the fix is merged to ncdns master, and I'd expect it to work fine. That said, I don't think we've done a huge amount of QA testing of master -- but on the other hand I'd be surprised if anything is significantly broken. I'm tentatively planning to tag a new release in January, but if NixOS needs a new tag quickly, let me know and I can try to expedite things. Cheers!

c00w commented 3 years ago

shrug January is likely fine :) - I'm just upgrading nixos to run of an unstable version of ncdns so we're unblocked. I also can't promise it will get merged quickly. I will note that if you tagged regular releases, nixos version upgrade infrastructure may have been able to automatically upgrade this package without a human being involved.

As a side note, any idea why it looks like all the namecoin repos aren't using go modules?