namecoin / ncdns

:globe_with_meridians: Namecoin to DNS bridge daemon

https://www.namecoin.org/

GNU General Public License v3.0

137 stars 41 forks source link

Automatically sync TLSA records with Firefox cert_override.txt #80

Closed JeremyRand closed 6 years ago

JeremyRand commented 6 years ago

Thanks for the review @hlandau , I'll fix the issues you identified soon.

JeremyRand commented 6 years ago

Okay, I think I've addressed all the feedback. This PR is now ready for review again, but shouldn't be merged until https://github.com/namecoin/ncdns/pull/82 is merged.

JeremyRand commented 6 years ago

82 is merged. @hlandau this PR is ready for review. Once you've reviewed my fixes for your feedback, I'll squash.

hlandau commented 6 years ago

ACK https://github.com/namecoin/ncdns/pull/80/commits/95a53599c73c59b9492c176ebd96916001ee375c

JeremyRand commented 6 years ago

Squashed.

JeremyRand commented 6 years ago

Added a documentation fix.

hlandau commented 6 years ago

ACK https://github.com/namecoin/ncdns/pull/80/commits/2fc7fa5de6951f25114e041bdd667d4bc7e04df8

JeremyRand commented 6 years ago

Squashed one last time.

hlandau commented 6 years ago

ACK https://github.com/namecoin/ncdns/pull/80/commits/fade5f412adf0b2b1bee51860d3eb46a11eb8976