search

namecoin / nmcontrol

Namecoin Control. This repo is deprecated in favor of https://github.com/namecoin/ncdns
136 stars 38 forks source link

Support for running as an Unbound Python module #72

Open JeremyRand opened 9 years ago

JeremyRand commented 9 years ago

@phelixbtc I realize you can't test this since you're on Windows; should we merge this or wait for someone else to review?

phelixbtc commented 9 years ago

I think 'name == "main"' all over the place should be replaced by a variable to the init function (e.g. "def init(standalone=True)". Like this it will not work with nmcontrolwin.py

edit: nitpick: missing CR at the end of files

JeremyRand commented 9 years ago

@phelixbtc Good feedback, I'll make those changes and get back to you.

JeremyRand commented 9 years ago

Upon talking to Hugo on IRC, I'm going to temporarily put this PR on hold. So don't merge at this time.