search

namecoin / nmcontrol

Namecoin Control. This repo is deprecated in favor of https://github.com/namecoin/ncdns
136 stars 38 forks source link

Fix various warnings/errors detected by PyLint #75

Open JeremyRand opened 9 years ago

JeremyRand commented 9 years ago

One of the fixes was in platform-dependent code, someone please test to make sure it still boots without exceptions on Windows.

phelixbtc commented 9 years ago

Why do you suggest to convert all the option dicts to lists?

JeremyRand commented 9 years ago

@phelixbtc Khal's code was converting dicts to lists at run time (but also accepted lists verbatim); that makes it impossible for PyLint to do static analysis of that code to check for errors.

phelixbtc commented 9 years ago

FTFY: https://github.com/namecoin/nmcontrol/pull/83

JeremyRand commented 9 years ago

Now that #83 is merged, I'll rebase this soon to not include that particular fix.