search

namecoin / nmcontrol

Namecoin Control. This repo is deprecated in favor of https://github.com/namecoin/ncdns
136 stars 38 forks source link

Win installer #86

Closed phelixbtc closed 9 years ago

phelixbtc commented 9 years ago

Windows installer script (Innosetup) with DnsPolicyConfig Registry Entry and autostart option.

phelixbtc commented 9 years ago

Automerge in 48h

JeremyRand commented 9 years ago

@phelixbtc As I have stated previously, I would very much prefer that we use NSIS for the Windows installer, because it's what Namecoin Core uses. Consistency with Namecoin Core is important because (1) it makes a bundle installer much easier, and (2) it's been tested by the Bitcoin devs for reproducible builds, which no one has tested Innosetup for.

(Please don't merge before we've agreed on the above.)

phelixbtc commented 9 years ago

Until somebody supplies that we should go with what we have. For now NMControl is separate from Namecoin Core anyway.

phelix commented 9 years ago

Unless somebody provides an NSIS installer I would like to merge this.

JeremyRand commented 9 years ago

@phelix I would be okay with having a separate branch in this repo for this. I would prefer not to have it in master or dns-dev.

phelix commented 9 years ago

Why? It's just one extra file. Once sombody comes up with an NSIS installer with similar functionality we can still remove it.

JeremyRand commented 9 years ago

@phelix Primarily because I don't want new contributors to have an incorrect impression that it's code that we want to keep. If they have that impression, they will potentially waste time building on that code, and that's unproductive for everyone.

phelixbtc commented 9 years ago

@JeremyRand The installer script is quite simple so I don't think that is a big issue in this case. What about I add a comment to the top of the script saying something like "Note: The installer might switch to NSIS some time in the future."

JeremyRand commented 9 years ago

@phelix I don't see a problem with keeping it in a separate branch from master/dns-dev. That way it's available for anyone who wants to use it, but we won't have people inadvertently committing code that depends on deprecated code.

phelixbtc commented 9 years ago

It makes things more complicated, particularly for me. When someone comes up with an NSIS installer (I don't see it coming atm) it will be removed.

phelixbtc commented 9 years ago

Automerge in 72h

JeremyRand commented 9 years ago

So, it looks like we'll be waiting for a while before @josephbisch's reproducible build system is fully working for Windows Python programs, and when it is working, we'll probably be removing PyInstaller in addition to InnoSetup. So, I am fine with merging this for the moment, on the condition that we add something to the readme saying that the Windows build system will be replaced, and therefore developers should not expend effort on the current Windows build system (other than basic maintenance). If that's okay with you, then feel free to merge.

JeremyRand commented 9 years ago

(If you merge it, please create a ticket or PR for the aforementioned readme change.)