search

namecoin / nmcontrol

Namecoin Control. This repo is deprecated in favor of https://github.com/namecoin/ncdns
136 stars 38 forks source link

Win fix pyinstaller #87

Closed phelixbtc closed 9 years ago

phelixbtc commented 9 years ago

from nmcontrol-hyperion

phelixbtc commented 9 years ago

Automerge in 48h

JeremyRand commented 9 years ago

@phelixbtc Do I understand correctly that this removes the Windows build of the console version, and instead only builds the GUI version? If so, I would very much prefer to build both, since some people will want the console version.

(Please don't automerge this until we've agreed on the above, and I have a chance to review the rest.)

phelixbtc commented 9 years ago

Why would anyone want the console version? I don't see a reason at the moment. If you think it is necessary I suggest to simply keep two batch files.

phelix commented 9 years ago

Automerge in 48h

JeremyRand commented 9 years ago

@phelix I think it's important to keep the console version available. Using two batch files seems like an okay solution. Temporary NACK until that is addressed; after it's addressed then untested ACK.

JeremyRand commented 9 years ago

Untested ACK.