search

namecoin / pkcs11mod

Go library for creating pkcs11 modules
GNU Lesser General Public License v2.1
7 stars 11 forks source link

Adding go.mod and go.sum to .gitignore #133

Closed robertmin1 closed 2 years ago

robertmin1 commented 2 years ago

Adding go.mod and go.sum to .gitignore

JeremyRand commented 2 years ago

Can you add a newline at the end of the file?

JeremyRand commented 2 years ago

ACK the content as of 54377691a8b6480496cbd9d315c90db188c1ca93.

Can you squash down to 1 commit, and change the commit message to use imperative tense ("Add") instead of present participle ("Adding")? Then I think it'll be ready to merge.

robertmin1 commented 2 years ago

Squashed the commits

JeremyRand commented 2 years ago

Tentative ACK 7f28016ff592b1d21256be89d39637783af43f1f, lemme check into why Cirrus is failing before I merge this.

JeremyRand commented 2 years ago

The Cirrus fails look spurious to me, I just triggered a rebuild, hopefully that'll resolve it.

robertmin1 commented 2 years ago

Okay!

JeremyRand commented 2 years ago

Still seeing spurious Cirrus fails. Should be fixed by https://github.com/namecoin/pkcs11mod/pull/135 but that won't help your PR unless you rebase, which is probably unnecessary here; I''ll just restart the failed builds a few times until they pass.

JeremyRand commented 2 years ago

ACK 7f28016ff592b1d21256be89d39637783af43f1f , merging.