Cirrus CI

[JeremyRand]

Namecoin's workflow requires Cirrus CI to be enabled (e.g. for static analysis, binary uploads, etc.). Can you copy the Cirrus config from one of Namecoin's repos? Basically copy .cirrus.yml, .golangci.yml, and the testdata folder from ncdns, and remove the go generate stuff that doesn't apply here.

[hlandau]

@JeremyRand https://github.com/hlandau/winsvcwrap/tree/ci

[JeremyRand]

https://github.com/hlandau/winsvcwrap/commit/4d3a9678a462e8f7a1987a7f25c13de2ed358278#diff-62587956f943bb2503db7bc6dd27d0d888074a1c0ecaab3f570ad611aff0f7bbR29

I think we can remove certinject and x509-compressed from this list? Ditto for anywhere else those two repos are mentioned in the Cirrus config.

[hlandau]

@JeremyRand Updated.

[JeremyRand]

Can you copy in the golangci config from ncdns (removing the x509-compressed reference)? That should get the linter to be a lot happier.

[JeremyRand]

Also, can you fix the three style issues reported by ifshort? https://github.com/hlandau/winsvcwrap/runs/5521920497

[JeremyRand]

Also please add the stylistic whitespace requested by the wsl linter: https://github.com/hlandau/winsvcwrap/runs/5521920504

[hlandau]

Can you copy in the golangci config from ncdns (removing the x509-compressed reference)? That should get the linter to be a lot happier. Done. variable 'err' is only used in the if-statement (main.go:81:2); consider using short syntax (ifshort) Not a bug. Also please add the stylistic whitespace requested by the wsl linter: https://github.com/hlandau/winsvcwrap/runs/5521920504 These are all BS.

[JeremyRand]

Alright, can you add ifshort to the disable list at https://github.com/hlandau/winsvcwrap/blob/fbfe43042e647418e4dec1256c7b215edd32af6c/.cirrus.yml#L41 so that Cirrus doesn't complain about it?

[hlandau]

@JeremyRand Done.