Open JeremyRand opened 2 years ago
@JeremyRand https://github.com/hlandau/winsvcwrap/tree/ci
I think we can remove certinject
and x509-compressed
from this list? Ditto for anywhere else those two repos are mentioned in the Cirrus config.
@JeremyRand Updated.
Can you copy in the golangci config from ncdns (removing the x509-compressed
reference)? That should get the linter to be a lot happier.
Also, can you fix the three style issues reported by ifshort
? https://github.com/hlandau/winsvcwrap/runs/5521920497
Also please add the stylistic whitespace requested by the wsl
linter: https://github.com/hlandau/winsvcwrap/runs/5521920504
Can you copy in the golangci config from ncdns (removing the x509-compressed reference)? That should get the linter to be a lot happier. Done. variable 'err' is only used in the if-statement (main.go:81:2); consider using short syntax (ifshort) Not a bug. Also please add the stylistic whitespace requested by the wsl linter: https://github.com/hlandau/winsvcwrap/runs/5521920504 These are all BS.
Alright, can you add ifshort
to the disable list at https://github.com/hlandau/winsvcwrap/blob/fbfe43042e647418e4dec1256c7b215edd32af6c/.cirrus.yml#L41 so that Cirrus doesn't complain about it?
@JeremyRand Done.
Namecoin's workflow requires Cirrus CI to be enabled (e.g. for static analysis, binary uploads, etc.). Can you copy the Cirrus config from one of Namecoin's repos? Basically copy
.cirrus.yml
,.golangci.yml
, and thetestdata
folder from ncdns, and remove thego generate
stuff that doesn't apply here.