search

named-data-iot / ndn-lite

A lightweight NDN protocol stack with high-level application support including security bootstrapping, access control, trust management, etc.
https://ndn-lite.named-data.net
GNU Lesser General Public License v3.0
44 stars 16 forks source link

Activate continuous integration in default branch #80

Closed yoursunny closed 4 years ago

yoursunny commented 4 years ago

Currently, Travis CI is enabled in develop branch only, and not activated in the default branch. This means, some incoming code targeting the default branch is not being CI-tested.

It is necessary to have CI testing, including unit tests, in the default branch.

yoursunny commented 4 years ago

Due to this issue, my recent bug reports are based on reviews on the develop branch, not the default branch. Likewise, I'll expect the bug fixes targeting develop or another CI-tested branch.

yan-foto commented 4 years ago

It was an unfortunate move to have multiple changes (CI integration included) in a single PR. If you guys have any quick tests at hand that can verify my changes in #74 so it can be merged to master? It would also bring CI to the master :)

tianyuan129 commented 4 years ago

after 6eb47ecca595ad9dc27d5000ff6fa64e975de17a, CI was now brought to master.

yoursunny commented 4 years ago

Travis CI badge in README should not explicitly link to master, because it's impractical to change the badge for each branch. Instead, leave off the branch and let it point to the latest build.

tianyuan129 commented 4 years ago

3faf4f2