search

named-data-mobile / ndn-photo-app

NDN Photo and File Sharing Application (npChat)
https://redmine.named-data.net/projects/npchat/issues
Other
27 stars 24 forks source link

Prevent overlapping of Images On Home Screen #144

Closed guy34code closed 5 years ago

guy34code commented 5 years ago

Description (required)

Fixes #142 {Use Layout_weight to prevent overlapping of Images On Home Screen}

Screenshots showing what changed (optional - for UI changes)

Before the Changes:

WhatsApp Image 2019-03-26 at 7 57 41 PM

After Changes:

WhatsApp Image 2019-03-26 at 10 38 28 PM

guy34code commented 5 years ago

@dev-ritik I accidently commit the changes to fix #143 under the same pull request. I'm new to open source and don't know much, Is there any way to create new pull request now for issue #143 ?

dev-ritik commented 5 years ago

@guy34code I would suggest you to create a new branch for #143 On the new branch, drop the commits of #142 while u rebase it. Make a new pull request for it. On the existing branch, make a hard reset to the extra commits. Force push the existing branch to update the PR.