fixes issue #143 added to register option if failed to register

named-data-mobile / ndn-photo-app

NDN Photo and File Sharing Application (npChat)

https://redmine.named-data.net/projects/npchat/issues

Other

27 stars 24 forks source link

fixes issue #143 added to register option if failed to register #172

Closed amitYadavDev closed 4 years ago

amitYadavDev commented 4 years ago

Screenshot_20200114-191540 Description (required)

Fixes #{GitHub issue number} {Github issue title}

What changes did you make and why?

Tests performed (required)

Tested {build variant, e.g. ProdDebug} on {name of device or emulator} with API level {API level}.

Screenshots showing what changed (optional - for UI changes)

Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

amitYadavDev commented 4 years ago

@jrandallclark please view my pr

jrandallclark commented 4 years ago

@jrandallclark please view my pr

Amit,

This PR doesn't address any of the points I brought up in the issue. Please look at my comments and follow the general guideline I established there if you would like to work on that issue.