Make a new UserProfile Section

named-data-mobile / ndn-photo-app

NDN Photo and File Sharing Application (npChat)

https://redmine.named-data.net/projects/npchat/issues

Other

27 stars 24 forks source link

Make a new UserProfile Section #48

Open shiv07tiwari opened 5 years ago

shiv07tiwari commented 5 years ago

As we are making an app for photo sharing inspired by Snapchat, we should make a UserProfile Section, where the user can see and change the following -

Profile Pic
Usename
Various Other personal details such as DOB, Gender, etc
Password change option can be provided here

Implementing this will allow us to remove the pic from the toolbar, which looks bad and doesnt follow the material design guidelines. Somewhat similar to this, with our fields.

shiv07tiwari commented 5 years ago

@agawande @jrandallclark Should I add this ?

jrandallclark commented 5 years ago

For now, users have no way of accessing each other's profiles, so this would not serve a purpose for the time being. This might be something we will look into later.

I'm curious as to why you think the picture in the toolbar looks bad and where in Google's material design guidelines it recommends against having it. Both Snapchat and Twitter include the user's profile picture in their top toolbar.

shiv07tiwari commented 5 years ago

@jrandallclark Its not for others to view someone else's profile, but for the user itself to change the password, username and profile picture.

I just think its not a good idea to place the pic in toolbar. It doesn't look good in my opinion. I also never saw such design in any of the designing courses, thus thought it isn't as per the conventional way.

jrandallclark commented 5 years ago

Ok. I will look into whether or not we should keep the profile picture in the toolbar, but we will keep it for now.

As for the username and password, the app does not support changing either of those. The user's name is a fundamental part how npChat works. (See https://github.com/named-data-mobile/ndn-photo-app/pull/19 & https://github.com/named-data-mobile/ndn-photo-app/issues/21) Because the user cannot log in and out, the password is not actually being used right now, so there is no need to change it either.

The user can already change their profile picture in the settings menu, as well.

shiv07tiwari commented 5 years ago

@jrandallclark Okay I missed the point that username is associated with the public key. Thanks.