search

named-data / StateVectorSync

Specification and API description of the State Vector Sync (SVS) protocol
https://named-data.github.io/StateVectorSync/
Creative Commons Attribution Share Alike 4.0 International
8 stars 0 forks source link

Specifying TLV types #9

Closed tylerliu closed 1 year ago

tylerliu commented 1 year ago

In C++ ndn-svs implementation, TLV type for SeqNo = 204; for Python SVS implementation, TLV type for SeqNo = 203.

Can we have specification for TLV types needed so there are inconsistency between implementations?

https://github.com/named-data/ndn-svs/blob/master/ndn-svs/tlv.hpp https://github.com/justincpresley/ndn-python-svs/blob/traditional/svs/tlv.py

Pesa commented 1 year ago

Can we have specification for TLV types needed so there are inconsistency between implementations?

We already have it: https://named-data.github.io/StateVectorSync/Specification.html and it says SeqNo has type 204.

(I don't know why 203 was skipped, but oh well...)

tylerliu commented 1 year ago

So Python Implementation got issues...

pulsejet commented 1 year ago

(I don't know why 203 was skipped, but oh well...)

No idea. It wasn't possible to create a backward compatible implementation anyway.

So Python Implementation got issues...

I think it's using the older spec here.