search

named-data / python-ndn

An NDN client library with AsyncIO support in Python 3
https://python-ndn.readthedocs.io/en/latest
Apache License 2.0
24 stars 17 forks source link

encoding: Fix InterestPacketValue class #17

Closed tuple71 closed 2 years ago

tuple71 commented 4 years ago

The InterestSignatureInfo element SHOULD include at least one of the following elements: SignatureNonce, SignatureTime, SignatureSeqNum.

Pesa commented 4 years ago

SHOULD != MUST Moreover, the choice of which signed Interest elements are included should be left up to the application (it's an app-level protocol decision). That's how we're implementing it in ndn-cxx: https://gerrit.named-data.net/c/ndn-cxx/+/6221

tuple71 commented 4 years ago

Currently, in the ndn-cxx/security/validation-policy-command-interest.cpp, ValidationPolicyCommandInterest::parseCommandInterest() is checked timestamp in case of SignedInterestFormat::V03.

tuple71 commented 4 years ago

I checked your implementation(https://gerrit.named-data.net/c/ndn-cxx/+/6221)

Pesa commented 4 years ago

Command interest is NOT equivalent to signed interest. Command interest is a special subcategory/extension of signed interest with more specific rules and is mostly a remnant of the old signed interest format.

tuple71 commented 4 years ago

I know. Signed interest is being implemented now and is not currently released on ndn-cxx master branch. When will it be released?

zjkmxy commented 4 years ago

Thank you for bringing this question up. These fields should be written by the signer, but I haven't written this part yet. Currently there is no stable application that is making use of these, so I don't know which one is better.

Pesa commented 3 years ago

I know. Signed interest is being implemented now and is not currently released on ndn-cxx master branch. When will it be released?

ndn-cxx-0.7.1 has a complete implementation of the v0.3 Signed Interest format.