search

namedtensor / notation

108 stars 5 forks source link

Derivatives #46

Closed davidweichiang closed 3 years ago

davidweichiang commented 3 years ago

45

davidweichiang commented 3 years ago
davidweichiang commented 3 years ago

I think it's really weird that elsewhere, where there is an input axis and an output axis, we used primes for the output axis, but here, we used primes for the input axis. Should we use a different symbol here? Or use primes on the output axes?

srush commented 3 years ago

We could use *

davidweichiang commented 3 years ago

I thought about that, but wondered if people are conditioned to think of x** and x as equivalent, which in this case they would not be...

davidweichiang commented 3 years ago

I also thought about switching the convention in the rest of the paper, but that doesn't work well with "return a scalar" trick (several functions would have only a foo' axis but no foo axis).

srush commented 3 years ago

I'm not sure this bothers me that much, but given that the grad_in is really a special symbol we could do something more aggressive like put a bar over it.

davidweichiang commented 3 years ago

bar looked kind of funny...I changed it to star.

srush commented 3 years ago

This seems ready to go to me. Maybe we can bump to v0.3 and update the website? Think there have been a bunch of recent changes.

srush commented 3 years ago

Oops sorry, crossed with your merge.

davidweichiang commented 3 years ago

Agreed, I think this is a good place to push to the website.