search

namedtensor / notation

108 stars 5 forks source link

Norms #48

Closed srush closed 3 years ago

srush commented 3 years ago

There is a bug in the xnorm function. The norms are a bit more complex than we have them written. I will do a pass and fix.

davidweichiang commented 3 years ago

Oh, sorry (I guess I'll find out what the bug was)

srush commented 3 years ago

Oh sorry, wasn't trying to be mysterious, just haven't gone through the details yet. When going through the pytorch docs, I realized that the gamma shape doesn't necessarily line up with the mean and variance as you might expect.

davidweichiang commented 3 years ago

Any progress on this?

srush commented 3 years ago

no, sorry, I will get to it this weekend.