search

namelessvoid / qrwar

:european_castle: Pen&Paper like quad ruled war game.
MIT License
6 stars 0 forks source link

res/ not installed #107

Closed AssociationSirius closed 5 years ago

AssociationSirius commented 5 years ago

This is not a bug but I warn you that the directory res is created when you unzip the file but it is empty. (which is normal because the data is in another archive)

You have to download the data archives and install them in the res directory.

If we click on the directory res @ 1407295 we get a page "not found error 404".

Could you just mention it in the readme file?

namelessvoid commented 5 years ago

If we click on the directory res @ 1407295 we get a page "not found error 404".

Once again I've forgotten to push the submodule as well. I just fixed it.

namelessvoid commented 5 years ago

So I decided to get rid of the submodule and include the resources into the main repository directly. Now, there is no need to download / checkout the resources separately.

The initial idea behind excluding the resources was to allow for others to provide custom tilesets. This however can be done in a better way anyways.

AssociationSirius commented 5 years ago

If you focus on the code, I think it's a good idea to merge. If then the amount of additional data explodes, returning to a separate source would be more convenient.

Le mer. 7 nov. 2018 à 20:02, Simon Kerler notifications@github.com a écrit :

Closed #107 https://github.com/namelessvoid/qrwar/issues/107.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/namelessvoid/qrwar/issues/107#event-1952472839, or mute the thread https://github.com/notifications/unsubscribe-auth/AJac98uRxeshXYX8hTWx0n0JIWITVRiDks5usy5XgaJpZM4X-kUb .