search

namelivia / fitbit-http-php

PHP SDK for accessing the Fitbit HTTP API
MIT License
10 stars 4 forks source link

The parameter for inputting the user goals period is probably bad designed #10

Open namelivia opened 5 years ago

namelivia commented 5 years ago

While documenting the goals retrieval function I noticed that probably the way of restricting the user input from 'daily' to 'weekly' by accepting an instance of GoalPeriod is convoluted and probably bad designed, an investigation on what could the best way of doing this should be done.

namelivia commented 5 years ago

This will apply to every enum like parameter on the application, I will leave this for later versions of the application.