search

namely / docker-protoc

Docker images for generating protocol buffer definitions
BSD 3-Clause "New" or "Revised" License
708 stars 225 forks source link

protoc java: --with-validator option not working #305

Closed venkatduddu closed 2 years ago

venkatduddu commented 2 years ago

I tried using the below command from the docker image 

/usr/local/bin/entrypoint.sh  --with-validator -d /defs/generated/proto/lakehouse/edge -i /defs/generated/proto -l java

Generated java class doesn't have the validate method added.

Looking at the code here https://github.com/namely/docker-protoc/blob/master/all/entrypoint.sh#L383-L396 looks like entry point is not considering validators for java it is only considering for go and gogo program languages.

Was this intentional or a bug?

ido-namely commented 2 years ago

Hi @venkatduddu , It seems like an oversight to me and not intentional. Not sure if we have the bandwidth atm to fix this but PRs are welcome :)

venkatduddu commented 2 years ago

Hi @ido-namely See if this helps. https://github.com/namely/docker-protoc/pull/306

ido-namely commented 2 years ago

addressed in https://github.com/namely/docker-protoc/pull/306